Skip to content

fix(dynamic tabs): styling issues form inherited styles#7055

Open
Eetwalt wants to merge 1 commit intomainfrom
dynamic-tabs-bg
Open

fix(dynamic tabs): styling issues form inherited styles#7055
Eetwalt wants to merge 1 commit intomainfrom
dynamic-tabs-bg

Conversation

@Eetwalt
Copy link
Collaborator

@Eetwalt Eetwalt commented Feb 6, 2026

Summary

Some unwanted styles are inherited from the skin by the new dynamic tabs, causing odd looking tabs on elements with background color.

This PR unsets the bg color and also overrides a couple properties originally used from skin so the implementation is more self-contained and not relying on skin

Context:
https://discord.com/channels/93055209017729024/1460560309050671196/1468353510818189332

How did you test this change?

dev tools

Before:
image

After:
image

@Eetwalt Eetwalt requested review from a team and Copilot February 6, 2026 14:37
@Eetwalt Eetwalt added the stylesheets Changes to stylesheets label Feb 6, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes styling issues in dynamic tabs caused by inherited styles from the skin. The changes ensure tabs render correctly on elements with background colors by unsetting inherited properties and making the implementation more self-contained.

Changes:

  • Unset background color on tab items to prevent inheritance issues
  • Add explicit display and list-style properties to override skin defaults

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stylesheets Changes to stylesheets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants