Conversation
not in this pr, maybe in subsequent pr(s) iirc there are some tiebreaker settings in match1 setup that block botting matches using those tiebreakers |
| MatchStandingsLegacy.readOpponents(args) | ||
| MatchStandingsLegacy.readBackground(args) | ||
|
|
||
| Variables.varDefine('islegacy', '') |
There was a problem hiding this comment.
why do we unset this var here?
There was a problem hiding this comment.
|detailsX= params are conditionally json strings depending on islegacy page var (ref:https://liquipedia.net/pubg/index.php?title=Template:MatchSummary&diff=556745&oldid=556058)
so it's to prevent uses outside of legacy wrapper from (theoretically) breaking
There was a problem hiding this comment.
in that case: do we need to reset it to its former value after the processing done in this module?
There was a problem hiding this comment.
I don't think we have to
the only place we define islegacy page var in pubg wiki is right before module invoke in template entrypoint (https://liquipedia.net/pubg/Template:LegacyMatchStandings)
|
|
||
| Variables.varDefine('islegacy', '') | ||
| return MatchGroup.MatchList(Json.stringifySubTables{ | ||
| return MatchGroup.Bracket(Json.stringifySubTables{ |
There was a problem hiding this comment.
It's not possible.to say that it should always be a Bracket/2 though.
Eg here it is clearly a matchlist https://liquipedia.net/pubg/PUBG_Development_League/2019/Spring/Division_A#Results
There was a problem hiding this comment.
well that is an inherent problem with pubg's match1 setup; it treated every match as single match (i.e., it had no notion of bracket/matchlist)
since match2 requires all matchgroups to be either one of brackets or matchlists, we would have to make compromise somewhere
There was a problem hiding this comment.
This is somewhat the issue I ran into with Apex when I was doing conversions;
If we want to ensure it's all done correctly; you kind of just need to manually sort through conversions generally to see what needs to be applied. (And to be fair; I also ended up merging a lot more pages, Where in the past for Apex' Challenger circuit, it was set as subpages for Quarters/Semis/Finals I then merged it unto a single bracket page)
4 participants
Summary
This PR adds legacy wrapper for Template:Match standings team in PUBG.
How did you test this change?
pubg:User:ElectricalBoy/Sandbox2