feat(TeamParticipant): add grouping option for participants#6986
Open
ElectricalBoy wants to merge 7 commits intomainfrom
Open
feat(TeamParticipant): add grouping option for participants#6986ElectricalBoy wants to merge 7 commits intomainfrom
ElectricalBoy wants to merge 7 commits intomainfrom
Conversation
ElectricalBoy
force-pushed
the
team-participant-groups
branch
from
e884fd5 to
74062a9
Compare
ElectricalBoy
force-pushed
the
team-participant-groups
branch
from
432cc5b to
f6c9f22
Compare
participantGroup may be empty, but never nil
hjpalpha
approved these changes
Jan 21, 2026
Collaborator
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
i think this is perf wise better than my solution (less invokes)^^
comment is optional
| local tabArgs = {} | ||
|
|
||
| Array.forEach(participantGroups, function (group, groupIndex) | ||
| tabArgs['name' .. groupIndex] = Logic.emptyOr(group[1].participantGroup, 'Unnamed') |
Collaborator
There was a problem hiding this comment.
not a fan of 'Unnamed' (Maybe 'Placeholder' or 'Missing |group='?)
maybe just throw if it is empty and we have >1 participantGroups?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inspired from #6985
This PR adds grouping option for team participants.
How did you test this change?
sandbox in LoL