Feature/graylog server #187
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NavidSassan
requested changes
Nov 5, 2025
| shards: 4 | ||
| title: 'Linuxfabrik Index Set (managed by Ansible - do not edit)' | ||
| writable: true | ||
| graylog_server__system_index_sets__dependent_var: [] |
Member
There was a problem hiding this comment.
both renaming the variable and changing the default is a (potentially) breaking change - document this clearly in the CHANGELOG.md
| Accept: 'application/json' | ||
| X-Requested-By: 'cli' | ||
| when: "graylog_server__get_index_sets_result | community.general.json_query(\"json.index_sets[?index_prefix==`\" ~ graylog_server__system_default_index_set['index_prefix'] ~ \"`].id\") | length == 0" | ||
| loop: '{{ graylog_server__system_index_sets__combined_var }}' |
Member
There was a problem hiding this comment.
since it is a combined_var the role needs to implement and correctly handle the state key
| headers: | ||
| X-Requested-By: 'cli' | ||
| when: "graylog_server__get_index_sets_result | community.general.json_query(\"json.index_sets[?index_prefix==`\" ~ graylog_server__system_default_index_set['index_prefix'] ~ \"`].id\") | length > 0" | ||
| # - name: 'Set default index set' |
Member
There was a problem hiding this comment.
why is this commented out? either remove dead code or add a default subkey to the graylog_server__system_index_sets__*_var
| graylog_server__system_inputs__dependent_var: [] | ||
| graylog_server__system_inputs__group_var: [] | ||
| graylog_server__system_inputs__host_var: [] | ||
| graylog_server__system_inputs__role_var: [] |
Member
There was a problem hiding this comment.
why did we remove the default values here? please explain the intended way to use the role in an "Post-Installation Steps" section in the README.md (have a look at the elasticsearch role)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.