Skip to content

parse dbc with istream instead of filename #27

Closed
@TheWhiteBug

Description

@TheWhiteBug

Hi Devon! Thanks for the great lib! I selected it because of its simplicity.

void DbcParser::parse_file(const std::string& file) {
	std::ifstream s(file.c_str());
(...)

The file argument is only needed for the ifstream .
I would suggest to expose an std::istream overload in which case hitting the filesystem would not be required.
This looks like a low hanging fruit while the current limitation causes my current project to depend on writable storage which is highly inconvenient.

Thanks in advance!
Also, reading the announcement, you can make it a c++17 project if you ask me :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions