Skip to content

Fix strncat warning by using local small buffer.#3715

Merged
andypugh merged 1 commit intoLinuxCNC:masterfrom
BsAtHome:fix_strncat-warning
Jan 22, 2026
Merged

Fix strncat warning by using local small buffer.#3715
andypugh merged 1 commit intoLinuxCNC:masterfrom
BsAtHome:fix_strncat-warning

Conversation

@BsAtHome
Copy link
Contributor

Fixes #3708.

Copy link
Collaborator

@smoe smoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not too much of a fan to have local_tmp reserved for every cp operation, but then again, the compiler likely optimizes this anyway and it is nice to keep the context together, indeed.

@BsAtHome
Copy link
Contributor Author

Besides, it is only used in saving the tool data and that happens, well, not very often and is not real-time relevant.

@smoe smoe added the 2.10-candidate would be nice to have fixed in 2.10 label Jan 22, 2026
@andypugh andypugh merged commit a743d12 into LinuxCNC:master Jan 22, 2026
98 of 154 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.10-candidate would be nice to have fixed in 2.10

Projects

None yet

Development

Successfully merging this pull request may close these issues.

emc/tooldata/tooldata_common.cc:253:40 strncat truncates

3 participants