Gmoccapy: Make value conversion independent of locale setting#3691
Merged
andypugh merged 2 commits intoLinuxCNC:masterfrom Jan 12, 2026
Merged
Conversation
Conversion of calculator entry to float is now independent of locale: 10,123 --> 10.123 10.123 --> 10.123 10.12,3 --> error 10,1 + 10.2 --> 20.3 The old behavior using atof() had issues but can be activated by setting 'self.use_localization = True'
Sigma1912
force-pushed
the
Gmoccapy_Calculator_widget_decimal_handling
branch
from
0d1ab62 to
546e437
Compare
Sigma1912
changed the title
Member
|
Looks good for me 👍 The tool table already accepts dot and comma, but the offset page currently doesn't. Can you change that? |
…etting Conversion of keyboard entries to float cells is now independent of locale: 10,123 --> 10.123 10.123 --> 10.123 10.12,3 --> error The old behavior using locale settings had issues but can be activated by setting 'self.use_localization = True'
Sigma1912
changed the title
Contributor
Author
|
Added another commit for the value conversion in the offsetpage widget. |
hansu
approved these changes
Jan 8, 2026
Member
|
It seems that it doesn't work in current master with locale de_DE. Weird, I am sure it had worked when it was merged.
@Sigma1912 can you have a look? |
Contributor
Author
|
My mistake, see #3789 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit for offsetpage_widget:
Conversion of calculator entry to float is now independent of locale:
10,123 --> 10.123
10.123 --> 10.123
10.12,3 --> error
10,1 + 10.2 --> error
The old behavior using locale setting can be activated by
setting 'self.use_localization = True'
Commit for Calculator_widget:
Conversion of calculator entry to float is now independent of locale:
10,123 --> 10.123
10.123 --> 10.123
10.12,3 --> error
10,1 + 10.2 --> 20.3
The old behavior using atof() had issues but can be activated by
setting 'self.use_localization = True'
For discussion see #3686