Set motion mode to FREE when volatile joints have been unhomed#3669
Closed
Sigma1912 wants to merge 1 commit intoLinuxCNC:masterfrom
Closed
Set motion mode to FREE when volatile joints have been unhomed#3669Sigma1912 wants to merge 1 commit intoLinuxCNC:masterfrom
Sigma1912 wants to merge 1 commit intoLinuxCNC:masterfrom
Conversation
Joints set to volatile are automatically unhomed when task state switches to OFF or ESTOP If a joint is unhomed motion state needs to be set to free Fixes LinuxCNC#3658
Sigma1912
force-pushed
the
fix_state_not_set_to_free_with_volatile_joints
branch
from
29e679d to
c29e9b1
Compare
Contributor
Author
|
Closing this for further investigation into failing tests. |
Contributor
Author
|
The reason some test are failing is that some of these tests actually run in unhomed mode. linuxcnc/src/emc/task/emctaskmain.cc Line 3228 in f25a2ed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Joints set to volatile are automatically unhomed when task state switches to OFF or ESTOP
If a joint is thus unhomed motion state needs to be set to 'free'
Fixes #3658