Gtk verser & little probe screen -fix timeout wait_complete

[zz912]

The default wait time for command.wait_complete() is 5 seconds.
If the probe movements lasted more than 5 seconds, they were interrupted, or the measurement behavior was unexpected.
I set the wait time for command.wait_complete() to 600 seconds, which is 10 minutes. If the time is exceeded during an extremely long measurement, the operator will be informed.

[andypugh]

Thanks. This seems sensible.

Perhaps the sample code segments on https://linuxcnc.org/docs/stable/html/config/python-interface.html should use an explicit timeout, until a day ago I thought that it waited indefinitely, and 5s seems very short for some possible commands (such as an MDI move)

[zz912]

until a day ago I thought that it waited indefinitely

I am not happy that the command.wait_complete() function waits 5 seconds. On the other hand, I understand the author's concerns that an infinite wait could often cause LCNC to freeze.

I have already learned to think about this and accept it. What I consider a problem is that this function does not inform in any way that an overtime has occurred.
Errors caused by this are very difficult to find. I wanted to change this https://forum.linuxcnc.org/38-general-linuxcnc-questions/52141-warning-python-waitcommandcomplete-timed-out , but this post did not generate much response. I would need help choosing a suitable way to inform the user that a timeout has occurred. I have already found cases where exceeding 5 seconds is used intentionally for the command.mdi() function, so this should be a non-violent form of informing the user. I find the use of fprintf() barbaric, I would like some debug message.

[andypugh]

Could wait_complete() hook into the linuxcnc.comand.display_msg(string) code? I think that is probably the same as the G-code (DEBUG, ....) which will print an informational message at the bottom of the GUI screen.

[zz912]

Are you using Gtk verser or little probe screen?
I would be happy for feedback.

Which GUI are you using?
I use Gmoccapy and it has no informational message at the bottom of the GUI screen.

Could wait_complete() hook into the linuxcnc.comand.display_msg(string) code?

What do you mean? Do you want to add a message for wait_complete() in the probe screen, or for all uses of wait_complete()?

Do you want add linuxcnc.comand.display_msg(string)? Or do you want replace self.add_history() by linuxcnc.comand.display_msg(string)?

[andypugh]

I was wondering if a timeout in wait_complete() should always pop-up a message, and be built-in to the wait_complete() code itself.
Eventually folk might get annoyed enough to fix it.

[zz912]

I was wondering if a timeout in wait_complete() should always pop-up a message, and be built-in to the wait_complete() code itself.
Eventually folk might get annoyed enough to fix it.

I agree with message built-in to the wait_complete() code itself.
https://forum.linuxcnc.org/38-general-linuxcnc-questions/52141-warning-python-waitcommandcomplete-timed-out
Nobody react for creating Pull Request.

I dont agree with pop-up message. There may be situations where timeout is used intentionally and it would be unnecessarily annoying. wait_complete() is very old function and it is used in many users plugin surely.
I think, this is example #2954 , where timeout is necessary.

[andypugh]

I wasn't meaning a modal must-be-acknowledged dialog, rather a message in the LinuxCNC "rtapi_print" stream (or equivalent) that would be shown in the message area of the GUI.

[zz912]

Hello,

I vote for silent message, but we can try message in GUI. What should I do now? Or how can I help you.