Add format length limit to prevent format-truncation warning#3272
Merged
andypugh merged 1 commit intoLinuxCNC:masterfrom Jan 15, 2025
Merged
Add format length limit to prevent format-truncation warning#3272andypugh merged 1 commit intoLinuxCNC:masterfrom
andypugh merged 1 commit intoLinuxCNC:masterfrom
Conversation
Collaborator
|
I suspect that no-one has ever used emclcd, but whilst it exists, it might as well compile cleany. |
Contributor
Author
It may need a caring hand. Well, a firm hand might be required. The code references "/dev/hda1". That is a long time ago I've seen that device. |
Collaborator
|
It is retained mainly as an example of a user interface using a different paradigm to Python + GUI framework. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A spurious format truncation warning appears when extra warnings are enabled (using g++ 14.2.1). This might be a false positive, but is easily fixed by limiting the expansion size. All the names have a maximum length of 20 characters so limiting the expansion to that length should be fine.