Fix implicitly-declared 'constexpr...' warnings#3267
Merged
andypugh merged 1 commit intoLinuxCNC:masterfrom Jan 11, 2025
Merged
Fix implicitly-declared 'constexpr...' warnings#3267andypugh merged 1 commit intoLinuxCNC:masterfrom
andypugh merged 1 commit intoLinuxCNC:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of warnings are detected when adding
-Wdeprecated-copy. Defining a copy-constructor in C++11 and beyond requires you to overload the operator= too, just as you probably need a destructor (rule-of-three).This PR fixes the warnings for posemath by simply disabling the appropriate define.
The EMC_TOOL_STAT class had a strange operator= override, making a copy and then returning another copy. This has been fixed in the PR to use standard const reference as argument and returning the new object. It also blocks any use of the copy-constructor to be sure to use the right assignment code.