Fix Py_UnbufferedStdioFlag deprecation warning#3265
Merged
rene-dev merged 1 commit intoLinuxCNC:masterfrom Jan 21, 2025
Merged
Conversation
Fix python initialization using config. Fix releasing python config after use.
Contributor
Author
|
@rene-dev: What is the status of this PR? |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of Py_UnbufferedStdioFlag has been deprecated in python 3.12 (current debian:sid and other distros) and will be removed in 3.14. This PR fixes the warning (see also: #3203) and also fixes additional problems with the PyConfig code.
@rene-dev: The python documentation states that you need to use Py_InitializeFromConfig() when you change the PyConfig and you need to release the configuration with PyConfig_Clear() (see: https://docs.python.org/3.12/c-api/init_config.html#initialization-with-pyconfig).
Note: the merging #2487 to fix a previous deprecation warning introducing use of PyConfig caused all python versions lower than 3.8 to fail or anything older than Bullseye (see https://wiki.debian.org/Python). Therefore, no CPP conditional are placed around the code to support older distributions.