Fix typos in src/hal directory#3253
Conversation
Found via `codespell -q 3 -S "*.po,*.pot,*.svg,*.ts,*.changes_es,./.git/logs,./share,./docs/man/es,./configs/attic,*_fr.*,*_es.*,README_es,./src/hal/classicladder" -L abd,alle,ans,apoints,atleast,ba,breal,bu,bulle,busses,checke,childs,collet,comando,commutated,componentes,currenty,dashs,doubleclick,dout,dum,etxt,extint,faktor,finis,fo,fpr,halp,ihs,indx,ine,inout,inport,ist,leadin,momento,mot,nce,nome,oder,ontext,ot,parm,parms,propertys,realy,rin,ro,seh,sems,ser,serie,splitted,smoe,tabl,te,tey,tre,trough,ue,ure,usin,varn,vell,wille,wont,wonte`
|
@c-morley can you look at the pyui.intilize code? |
|
yes 'pyui.intilize = pyui.instance.build(2)' can be shortened to 'pyui.instance.build(2)' |
|
please advise? |
How I read it, the newly generated otherwise unused variable "pyui.initilize" catches the return variable of the function "pyui.instance.build()". So, instead of executing the assignment "newvar = somefunction(X)" for which somefunction(X) was executed, the suggestion is to only write "somefunction(X)" and thus only execute the function but ignore its return value. In other words: You can happily remove all occurrences of "pyui.intilize = " from the code. |
|
Yes exactly - sorry for not being clearer. |
Should I include that in this PR or spin it off into a separate one ? |
|
As far as I am concerned you can put it in this one. |
|
Done, please review. Do you want me to squash or |
|
I merged them as two separate commits. I considered merging but decided it was a cleaner commit history if they stayed separate. |
Found via
codespell -q 3 -S "*.po,*.pot,*.svg,*.ts,*.changes_es,./.git/logs,./share,./docs/man/es,./configs/attic,*_fr.*,*_es.*,README_es,./src/hal/classicladder" -L abd,alle,ans,apoints,atleast,ba,breal,bu,bulle,busses,checke,childs,collet,comando,commutated,componentes,currenty,dashs,doubleclick,dout,dum,etxt,extint,faktor,finis,fo,fpr,halp,ihs,indx,ine,inout,inport,ist,leadin,momento,mot,nce,nome,oder,ontext,ot,parm,parms,propertys,realy,rin,ro,seh,sems,ser,serie,splitted,smoe,tabl,te,tey,tre,trough,ue,ure,usin,varn,vell,wille,wont,wonteQuick question: I found these source typos
linuxcnc/src/hal/components/panelui.c
Lines 222 to 226 in c903ccd
(
intilize->initialize) but didn't include them. Please advise.