Skip to content

Conversation

0xK1r4n
Copy link
Contributor

@0xK1r4n 0xK1r4n commented Feb 23, 2025

I used a newer Amazon Corretto image because the current one has vulnerabilities, and I opted for an Alpine-based image, which results in a smaller Docker image file (approximately 600~ MB compared to 800+ MB).

image
image

I have tested a similiar build of the image with a custom Docker image that I personally use (which includes pre-installed SQLite binaries)

@0xK1r4n
Copy link
Contributor Author

0xK1r4n commented Feb 23, 2025

If you're interested, I can modify this PR to create a Docker image that runs SQLite by default. The user would only need to set the LINKORA_SERVER_AUTH_TOKEN and a volume to mount the DB (to persist data on server updates) to have the server up and running.

@sakethpathike
Copy link
Member

sakethpathike commented Feb 23, 2025

while it can be helpful, i also need to change the setup and some other stuff that connects to db to make it work as expected, which i am now not interested in 😅;

also i'm not sure how this would be handled on remote services. for example, render (which i use) does have docker deployments, but i don't think they provide volumes, but have some different thing going on for persistence, so the idea of providing db stuff by default makes complete sense for local hosting, but i'm not sure how this is going to be on remote.

@sakethpathike sakethpathike merged commit e1b1b64 into LinkoraApp:master Feb 23, 2025
@0xK1r4n 0xK1r4n deleted the docker-updates branch February 24, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants