Skip to content

Correct typo in spectral analysis Notebook #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

tomarney
Copy link
Contributor

@tomarney tomarney commented Nov 7, 2024

The call to interp() in the Spectral Analysis notebook ("Effect of Regridding" section) uses the Series.value to calculate min and max step, but it should be the Sries.time property.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CommonClimate
Copy link
Contributor

Hi @tomarney. Good catch and thank you for making this PR, which I only just noticed.
I'm surprised the results appear nearly unchanged before/after the change, though. Either something is very fishy, or there is a miraculous conspiring of numbers. In any case, I realized when reviewing your work that the better way to do this was to use the Resolution class, so I added that to your PR, and will now close it.

@CommonClimate CommonClimate merged commit 8a6ce85 into LinkedEarth:main Nov 20, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants