Extend logging #70
Merged
Extend logging #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support logging to STDOUT via setting `logging.file` to `false` and customization of log format with `logging.format`. The default value `null` falls back to default format. Custom format is required for proper logging behind a reverse proxy to log the remote IP from HTTP header `X-Forwarded-For` instead of the proxy IP.
RubenVerborgh
approved these changes
Jan 2, 2018
|
Looks good to me. However, in practice, I always set up the logging on the reverse proxy instead. This is because of caching, since not all requests arrive at the LDF server anyways. Here is what I'm doing on fragments.dbedia.org. |
rubensworks
approved these changes
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support logging to STDOUT via setting
logging.filetofalseandcustomization of log format with
logging.format. The default valuenullfalls back to default format. Custom format is required forproper logging behind a reverse proxy to log the remote IP from HTTP
header
X-Forwarded-Forinstead of the proxy IP.