Fix: PHP 7.4 cli logs in stderr output #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtils
reviewed
Feb 25, 2020
For that, I had to rewrite the test too
rgdevment
reviewed
Feb 25, 2020
Yaumel9
approved these changes
Feb 25, 2020
rgdevment
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm writing this PR to present a small patch to handle a new behavior of the PHP 7.4 CLI: it is attaching log messages of the built-in PHP server (
php -S) to thestderrpipe.Moreover, I opened an issue to discuss this problem with the guys from
internations/http-mock(InterNations#53). At a first glance I thought it wasn't a problem of http mock itself but since this behavior was introduced only in PHP 7.4, they found feasible the idea of adding a patch to get the library working with the new version of PHP.Since there isn't a builtin CLI option to change this behavior, I'm presenting the same solution here.
Let me know what you think of this approach to tackle this issue.
If you have a better solution in mind, I'll be glad to hear and discuss more about it! 😃