This repository was archived by the owner on Feb 15, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Add Local Font Change #96
Open
ReiFan49
wants to merge
10
commits into
LingFeng-bbben:master
Choose a base branch
from
ReiFan49:add/dev-font-change
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Owner
|
There are lots of native TEXT component to be replaced. Need more work here. |
ReiFan49
commented
Mar 21, 2023
Assets/Scenes/SampleScene.unity
Outdated
| AllPerfectFont: {fileID: 11400000, guid: 75efbe0ae053d5c4a9a6983514232a25, type: 2} | ||
| SongInfoFont: {fileID: 11400000, guid: 75efbe0ae053d5c4a9a6983514232a25, type: 2} | ||
| SideInfoFont: {fileID: 11400000, guid: 75efbe0ae053d5c4a9a6983514232a25, type: 2} | ||
| CenterInfoFont: {fileID: 11400000, guid: 75efbe0ae053d5c4a9a6983514232a25, type: 2} |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no need to fill this on, as leaving them Global only, or Full blank would make whoever doing building this locally could fit their own values.
Contributor
Author
|
I think leaving some on Native Text is ok, like Song Detail's. Object Info is one of the potential target of this don't you think so? |
leave this values for "easy adjustment" on developers/compilers for personal use, no need to enforce this for public build.
the outline from first commit is too thick, yet the followup commit is too thin. value around 0.35~0.38 should be good for this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor change that allows easy local customization without breaking the whole unity scene file due to mass font changing.
To use it, simply go to
LocalFontDevobject and locate the script as the picture above. Each field requires aTMP_FontAssetor TextMeshPro Font Asset which is derived from the font directly. This will allow development specific to change into their own favored font in case the font itself aren't "allowed" to be published.The changes will apply to any
TextandTextMeshPro UIelements. TheGlobal Fontfield is the first fallback if the specific fields are unset.Aside from local font changing feature, this change also made Center Information values (Score, Combo, Achievement, and DXScore) are monospaced. So any padding done by 2c5c48b is covered properly along this change.