Skip to content

Add comprehensive test suite for SEFR and LinearBoostClassifier estimators #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

msamsami
Copy link
Contributor

@msamsami msamsami commented Jun 8, 2025

This PR introduces a comprehensive test suite for both SEFR and LinearBoostClassifier estimators and a few minor changes to the source code.

Comprehensive Test Suite

This test suite ensures that both estimators are robust, reliable, and fully compatible with the scikit-learn ecosystem while maintaining high code quality standards. The added test categories include:

  • Initialization & Parameter Validation: Ensures proper setup with all parameter combinations
  • Fitting & Training: Validates model training across different data scenarios
  • Prediction & Inference: Comprehensive testing of all prediction methods
  • Error Handling: Robust validation of error cases and edge conditions
  • Mathematical Properties: Ensures numerical stability and algorithmic correctness
  • Integration Testing: Dataset validation and sklearn compatibility

Minor Changes

  • Removed unsupported class weight option: Dropped balanced_subsample from LinearBoostClassifier as it's not supported by Scikit-learn's compute_sample_weight.
  • Added test coverage pragma: Added pragma comment to typing import in sefr.py and linear_boost.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant