Apply highlighting to more builtin forms by default #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing logic already works well enough. It is enough to just add these forms to the default values. - let forms like if/when-let and letrec - builtin define-inline also has the same syntax as defun - try to highlight pcase-lambda and pcase-dolist like has already been done for pcase-let - highlight variants of condition-case While not all features of all forms* here are highlighted, this is already more useful than not applying the highlighting to them. *: like when-let and if-let's variable omitting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing logic already works well enough. It is enough to just add these forms to the default values.
While not all features of all forms* here are highlighted, this is already more useful than not applying the highlighting to them.
*: like when-let and if-let's variable omitting