fix binaryen epoch injection module name#631
Merged
rennergade merged 1 commit intomainfrom Jan 25, 2026
Merged
Conversation
Contributor
End-to-End Test ReportTest PreviewTest Report Deterministic TestsSummary
Test Results by Category
Non Deterministic TestsSummary
Test Results by Category
Fail TestsSummary
Test Results by Category
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
stupendoussuperpowers
added a commit
that referenced
this pull request
Jan 25, 2026
stupendoussuperpowers
approved these changes
Jan 25, 2026
Contributor
stupendoussuperpowers
left a comment
stupendoussuperpowers
left a comment
There was a problem hiding this comment.
Changes look good to me, both here and on the binaryen repo.
I would suggest at the very least having a documentation issue open on the Lind-Wasm repo so that we can reference the changes we needed to make to binaryen.
Contributor
Yeah we should host this ourselves just not as a submodule. If we host it here @m-hemmings can set it up so we build wasm-opt from the external repo as part of our weekly builds. |
rennergade
approved these changes
Jan 25, 2026
Contributor
rennergade
left a comment
rennergade
left a comment
There was a problem hiding this comment.
Approved. Lets setup the wasm-opt repo this week.
rennergade
pushed a commit
that referenced
this pull request
Jan 26, 2026
…627) * Add unified cargo compilation support. - Add cargo-lind_compile global binary - Add lind::epoch_callback in the linker * Remove trailing escape sequence * Add symlink to lind-cargo * Handle epoch_callback change in #631 * wasip1-clang.sh: Fix the REPO_ROOT, chmod +x * Update docs: compiling rust, getting started * Remove .DS_Store * Alias => lind-cargo-build * More detailed contrib docs
celinehoang177
pushed a commit
that referenced
this pull request
Feb 2, 2026
celinehoang177
pushed a commit
that referenced
this pull request
Feb 2, 2026
…627) * Add unified cargo compilation support. - Add cargo-lind_compile global binary - Add lind::epoch_callback in the linker * Remove trailing escape sequence * Add symlink to lind-cargo * Handle epoch_callback change in #631 * wasip1-clang.sh: Fix the REPO_ROOT, chmod +x * Update docs: compiling rust, getting started * Remove .DS_Store * Alias => lind-cargo-build * More detailed contrib docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed lind's
wasm-optso that it always useslindas the module name for epoch injectionsThe modified binaryen source code are here: https://github.com/qianxichen233/binaryen-epoch-injection
Do we need to move this repo into lind-project's repos? @rennergade