Add Example Grate: In Memory File System by stupendoussuperpowers · Pull Request #4 · Lind-Project/lind-wasm-example-grates

stupendoussuperpowers · 2025-09-20T21:07:18Z

Closes: #2

rennergade · 2025-09-24T03:50:41Z

examples/imfs-grate/compile_grate.sh

@@ -0,0 +1,4 @@
+#!/bin/bash
+
+/home/lind/lind-wasm/clang+llvm-16.0.4-x86_64-linux-gnu-ubuntu-22.04/bin/clang -pthread --target=wasm32-unknown-wasi --sysroot /home/lind/lind-wasm/src/glibc/sysroot -Wl,--import-memory,--export-memory,--max-memory=1570242560,--export=signal_callback,--export=__stack_pointer,--export=__stack_low,--export=open_grate,--export=close_grate,--export=lseek_grate,--export=read_grate,--export=write_grate,--export=fcntl_grate,--export-table imfs_grate.c imfs.c -g -DLIB -DDIAG -D_GNU_SOURCE -O0 -o imfs_grate.wasm && /home/lind/lind-wasm/tools/binaryen/bin/wasm-opt --epoch-injection --asyncify -O2 --debuginfo imfs_grate.wasm -o imfs_grate.wasm && /home/lind/lind-wasm/src/wasmtime/target/release/wasmtime compile imfs_grate.wasm -o imfs_grate.cwasm


is this custom per grate or extensible?

For now it is per grate since we need to specify which grate functions are exported. I believe Alice is working on a way around this, so that we don't need to do function dispatches based on exports.

marcelamelara

Thanks! I've reviewed the README, and have a few places where I think clarification would help. I also think we should revisit some default settings, if possible.

examples/imfs-grate/README.md

This reverts commit 81ffefd.

- Fix comments on the README - Working version compatible with lind-wasm changes - New folder structure + compile script for grates - Add tests, remove random logs - clang-format

stupendoussuperpowers · 2025-12-23T15:48:35Z

Re-requesting review from @rennergade and @Yaxuan-w. Need inputs on this:

I've changed the structure to be more uniform, with source code in the src/ folder and the tests in the tests/ folder.
Additionally, there's a build.conf file that is expected in the root of every grate, this is because we need to know the entry point for this grate. Optionally, you can also pass down --max-memory or C_FLAGS as needed, they were needed for IMFS and will likely be needed for other grates as well.
Right now, I've added a compile_grate.sh in the imfs folder, which works like ./compile_grate.sh <folder for the grate>. This will be moved outside of the example repo once I file an Issue to provide general purpose tools/templates to this repo.

My basic logic is that we should ideally have a uniform way for building and running these example grates.

J7-7-7 · 2025-12-29T20:36:50Z

compile_grate.sh hard-codes toolchain paths under /home/lind/..., could we make these env-overridable (or derived from LIND_WASM_ROOT) so it's easier?

build.conf sets C_FLAGS=... but the script only reads EXTRA_CFLAGS, so those flags never get applied unless users manually set EXTRA_CFLAGS

rennergade

I think this looks good. @Yaxuan-w can you review when you have a chance? Feel free to merge if you approve

Yaxuan-w

Great job! Would be helpful to have comments about general description and functionality at top of each file

Yaxuan-w · 2026-01-07T18:42:27Z

examples/imfs-grate/src/imfs_grate.c

Need more comments

Yaxuan-w · 2026-01-07T18:42:54Z

examples/imfs-grate/compile_grate.sh

Comments on usage

Yaxuan-w · 2026-01-07T18:44:13Z

Also, would be helpful to open up an issue about adding more tests about imfs

- Reset doomed to 0 on reallocated nodes. - Terminate strings with \0 in add_child. - Fix offset math in imfs_write. - Use _USR instead of _OTH for access checks. - Add added access checks on read and write.

examples/imfs-grate/src/imfs_grate.c

stupendoussuperpowers · 2026-01-24T23:54:04Z

Re-requesting review from @Yaxuan-w, have addressed the comments about more documentation on imfs_grate and compile_grate script. Also added more thorough tests for testing the imfs with the grate in lind.

Yaxuan-w

LGTM! But I'm a bit worried about the register_handler usage would need to update after refactoring PR being merged

stupendoussuperpowers added 2 commits September 20, 2025 16:55

Add IMFS example grate

84301e8

clang-format imfs_grate.c file

55b4693

stupendoussuperpowers requested a review from rennergade September 20, 2025 21:07

rennergade reviewed Sep 24, 2025

View reviewed changes

stupendoussuperpowers mentioned this pull request Sep 24, 2025

Add documentation for In Memory File System Lind-Project/lind-wasm#367

Closed

Yaxuan-w requested review from Yaxuan-w and marcelamelara September 24, 2025 20:30

marcelamelara requested changes Oct 10, 2025

View reviewed changes

stupendoussuperpowers added 3 commits October 20, 2025 12:57

Fix comments.

40547bc

Add compile tools + new API support

81ffefd

Revert "Add compile tools + new API support"

b8c2321

This reverts commit 81ffefd.

stupendoussuperpowers mentioned this pull request Dec 20, 2025

Grates Implementation Tracker #6

Open

19 tasks

IMFS Updates

70628ac

- Fix comments on the README - Working version compatible with lind-wasm changes - New folder structure + compile script for grates - Add tests, remove random logs - clang-format

stupendoussuperpowers requested a review from rennergade December 23, 2025 15:48

rennergade requested a review from J7-7-7 December 23, 2025 16:09

stupendoussuperpowers added 2 commits December 31, 2025 15:04

Update compile script.

eb573fb

Build.conf: Fix CFLAGS var

8255af8

rennergade approved these changes Dec 31, 2025

View reviewed changes

Yaxuan-w requested changes Jan 7, 2026

View reviewed changes

stupendoussuperpowers added 7 commits January 13, 2026 00:23

Add more comments

bf12607

Fix edge-case issues.

003489b

- Reset doomed to 0 on reallocated nodes. - Terminate strings with \0 in add_child. - Fix offset math in imfs_write. - Use _USR instead of _OTH for access checks. - Add added access checks on read and write.

Change MAX_NODES

235610e

Add unlink support. Copy count instead of default 256 in write_grate.

99733da

Rewrite tests to be more exhaustive

ed057fa

compile script: CLANG => Directory instead of /bin/clang

830982f

tests: send FAIL log to stdout instead of stderr

7679866

rennergade reviewed Jan 23, 2026

View reviewed changes

examples/imfs-grate/src/imfs_grate.c Outdated Show resolved Hide resolved

Preloads can be performed before fork as well.

a4992ae

stupendoussuperpowers requested a review from Yaxuan-w January 24, 2026 18:04

stupendoussuperpowers added 2 commits January 26, 2026 15:55

Optimize memory usage for nodes

14c5a47

Perform register_handling in the grate

d1ad2c6

Yaxuan-w approved these changes Jan 27, 2026

View reviewed changes

rennergade merged commit 62e6517 into Lind-Project:main Jan 28, 2026

		@@ -0,0 +1,4 @@
		#!/bin/bash

		/home/lind/lind-wasm/clang+llvm-16.0.4-x86_64-linux-gnu-ubuntu-22.04/bin/clang -pthread --target=wasm32-unknown-wasi --sysroot /home/lind/lind-wasm/src/glibc/sysroot -Wl,--import-memory,--export-memory,--max-memory=1570242560,--export=signal_callback,--export=__stack_pointer,--export=__stack_low,--export=open_grate,--export=close_grate,--export=lseek_grate,--export=read_grate,--export=write_grate,--export=fcntl_grate,--export-table imfs_grate.c imfs.c -g -DLIB -DDIAG -D_GNU_SOURCE -O0 -o imfs_grate.wasm && /home/lind/lind-wasm/tools/binaryen/bin/wasm-opt --epoch-injection --asyncify -O2 --debuginfo imfs_grate.wasm -o imfs_grate.wasm && /home/lind/lind-wasm/src/wasmtime/target/release/wasmtime compile imfs_grate.wasm -o imfs_grate.cwasm

Conversation

stupendoussuperpowers commented Sep 20, 2025

Uh oh!

rennergade Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

stupendoussuperpowers Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

marcelamelara left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stupendoussuperpowers commented Dec 23, 2025

Uh oh!

J7-7-7 commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rennergade left a comment

Choose a reason for hiding this comment

Uh oh!

Yaxuan-w left a comment

Choose a reason for hiding this comment

Uh oh!

Yaxuan-w Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Yaxuan-w Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Yaxuan-w commented Jan 7, 2026

Uh oh!

Uh oh!

stupendoussuperpowers commented Jan 24, 2026

Uh oh!

Yaxuan-w left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

J7-7-7 commented Dec 29, 2025 •

edited

Loading