We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlobFilehandleWrapper module code was copied from JBrowse in #98 along with others to modify file retrieval code to support GDC authentication token.
As I pointed out in the PR, BlobFilehandleWrapper seemed unnecessary to copy since it appeared to be unchanged from the original.
It turns out the return statement here was changed (probably for some local testing?) and breaks BAM retrieval in the @gmod/bam code: https://github.com/LincolnSteinLab/gdc-viewer/blob/develop/gdc-viewer/js/Model/BlobFilehandleWrapper.js#L14 https://github.com/GMOD/jbrowse/blob/master/src/JBrowse/Model/BlobFilehandleWrapper.js#L14 https://github.com/GMOD/bam-js/blob/master/src/bamFile.ts#L114
@gmod/bam
Best fix is to delete BlobFilehandleWrapper copy and use the JBrowse version.
The text was updated successfully, but these errors were encountered:
GFJHogue
Successfully merging a pull request may close this issue.
BlobFilehandleWrapper module code was copied from JBrowse in #98 along with others to modify file retrieval code to support GDC authentication token.
As I pointed out in the PR, BlobFilehandleWrapper seemed unnecessary to copy since it appeared to be unchanged from the original.
It turns out the return statement here was changed (probably for some local testing?) and breaks BAM retrieval in the
@gmod/bam
code:https://github.com/LincolnSteinLab/gdc-viewer/blob/develop/gdc-viewer/js/Model/BlobFilehandleWrapper.js#L14
https://github.com/GMOD/jbrowse/blob/master/src/JBrowse/Model/BlobFilehandleWrapper.js#L14
https://github.com/GMOD/bam-js/blob/master/src/bamFile.ts#L114
Best fix is to delete BlobFilehandleWrapper copy and use the JBrowse version.
The text was updated successfully, but these errors were encountered: