Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: account for differences in OS path separators #6

Merged
merged 1 commit into from
Jul 25, 2022
Merged

fix: account for differences in OS path separators #6

merged 1 commit into from
Jul 25, 2022

Conversation

pablohoch
Copy link
Contributor

The current version no longer works on Windows, because file paths are split using "/" as a separator. This PR fixes that by using path.sep as the separator (and path.join for the tests).

Limegrass
Limegrass requested changes Jul 22, 2022
View reviewed changes
Copy link
Owner

@Limegrass Limegrass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix! The change looks good, but I had a suggestion on the tests.

Also, another nitpick: do you mind renaming the commit message to something like fix: account for differences in OS path separators?

tests/rules/import-alias.test.ts Outdated Show resolved Hide resolved
@pablohoch pablohoch changed the title fix: windows support fix: account for differences in OS path separators Jul 22, 2022
@Limegrass Limegrass merged commit af01b14 into Limegrass:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Limegrass Limegrass Limegrass requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablohoch @Limegrass