Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add fairscale to VISSL requirements #909

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the bug / fix Something isn't working label Nov 2, 2021
@@ -10,3 +10,4 @@ learn2learn
structlog==21.1.0 # remove when baal resolved its dependency.
baal
fastface
fairscale
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this required?

Copy link
Collaborator Author

@ethanwharris ethanwharris Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VISSL tests require it but somehow it isn't listed in their requirements. I think because it used to get installed with PL maybe? Actually looks liek VISSL made a new version that removes it from their reqs. for some reason...

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #909 (6619bd4) into master (7618408) will decrease coverage by 3.77%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
- Coverage   82.34%   78.57%   -3.78%     
==========================================
  Files         237      237              
  Lines       12885    12885              
==========================================
- Hits        10610    10124     -486     
- Misses       2275     2761     +486     
Flag Coverage Δ
unittests 78.57% <100.00%> (-3.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/embedding/model.py 41.66% <100.00%> (ø)
flash/text/question_answering/model.py 28.27% <0.00%> (-62.76%) ⬇️
flash/text/question_answering/data.py 27.93% <0.00%> (-59.05%) ⬇️
flash/text/classification/cli.py 53.84% <0.00%> (-46.16%) ⬇️
flash/text/classification/data.py 55.49% <0.00%> (-41.89%) ⬇️
flash/text/question_answering/cli.py 60.00% <0.00%> (-40.00%) ⬇️
flash/text/seq2seq/core/utils.py 70.00% <0.00%> (-30.00%) ⬇️
flash/text/seq2seq/core/metrics.py 74.07% <0.00%> (-25.00%) ⬇️
flash/text/seq2seq/core/data.py 65.85% <0.00%> (-24.40%) ⬇️
flash/text/classification/model.py 68.51% <0.00%> (-24.08%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7618408...6619bd4. Read the comment docs.

@ethanwharris ethanwharris merged commit 4751d7e into master Nov 2, 2021
@ethanwharris ethanwharris deleted the bugfix/fairscale branch November 2, 2021 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants