Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Set logo to have a white background for dark mode #757

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Sep 14, 2021

Adds a white outline to the lightning flash logo which is only visible in dark mode on github.

Now it would pass a contrast checker, helpful for accessibility :)

Before:
Screenshot 2021-09-14 at 16 53 03
After:
Screenshot 2021-09-14 at 16 52 54

cc @phoebynaren who sent this to me :)

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #757 (081b110) into master (eaa0e96) will decrease coverage by 4.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #757      +/-   ##
==========================================
- Coverage   89.65%   84.98%   -4.68%     
==========================================
  Files         198      198              
  Lines       10681    10681              
==========================================
- Hits         9576     9077     -499     
- Misses       1105     1604     +499     
Flag Coverage Δ
unittests 84.98% <ø> (-4.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/text/question_answering/model.py 29.16% <0.00%> (-61.81%) ⬇️
flash/graph/classification/model.py 38.70% <0.00%> (-61.30%) ⬇️
flash/text/question_answering/data.py 28.29% <0.00%> (-57.88%) ⬇️
flash/graph/data.py 45.00% <0.00%> (-50.00%) ⬇️
flash/graph/classification/cli.py 42.85% <0.00%> (-50.00%) ⬇️
flash/text/classification/cli.py 57.14% <0.00%> (-42.86%) ⬇️
flash/text/question_answering/cli.py 58.33% <0.00%> (-41.67%) ⬇️
flash/text/seq2seq/core/utils.py 70.00% <0.00%> (-30.00%) ⬇️
flash/graph/classification/data.py 64.28% <0.00%> (-28.58%) ⬇️
flash/text/classification/data.py 62.92% <0.00%> (-28.09%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaa0e96...081b110. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@SeanNaren SeanNaren enabled auto-merge (squash) September 14, 2021 16:10
@ethanwharris ethanwharris merged commit c06ebce into master Sep 14, 2021
@ethanwharris ethanwharris deleted the fix/logo branch September 14, 2021 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants