Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Make IceVision requirements fully optional #742

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #742 (0dcede6) into master (b55f08e) will increase coverage by 0.00%.
The diff coverage is 98.48%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #742   +/-   ##
=======================================
  Coverage   89.64%   89.65%           
=======================================
  Files         198      198           
  Lines       10653    10662    +9     
=======================================
+ Hits         9550     9559    +9     
  Misses       1103     1103           
Flag Coverage Δ
unittests 89.65% <98.48%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/utilities/imports.py 91.11% <94.44%> (+0.63%) ⬆️
flash/audio/speech_recognition/data.py 89.92% <100.00%> (ø)
flash/core/integrations/icevision/transforms.py 72.50% <100.00%> (ø)
flash/core/model.py 87.11% <100.00%> (ø)
flash/core/serve/component.py 94.33% <100.00%> (ø)
flash/core/serve/core.py 87.87% <100.00%> (ø)
flash/graph/data.py 95.00% <100.00%> (ø)
flash/image/classification/data.py 94.11% <100.00%> (ø)
flash/image/data.py 95.45% <100.00%> (ø)
flash/image/detection/model.py 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b55f08e...0dcede6. Read the comment docs.

@aniketmaurya
Copy link
Contributor

@ethanwharris much needed one 😄

@ethanwharris ethanwharris merged commit 143112d into master Sep 7, 2021
@ethanwharris ethanwharris deleted the feature/optional_reqs branch September 7, 2021 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants