Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix CI compatibility with TM 0.8 #1296

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Apr 15, 2022

What does this PR do?

TM 0.8 is not compatible with old versions of PL (pre 1.5). Some of our requirements pin versions of PL so we need to also pin torchmetrics in these cases.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added bug / fix Something isn't working tests / CI Tests and continuous integration labels Apr 15, 2022
@ethanwharris ethanwharris added this to the 0.7.x milestone Apr 15, 2022
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #1296 (ab4ff91) into master (4aeffce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1296   +/-   ##
=======================================
  Coverage   91.71%   91.71%           
=======================================
  Files         285      285           
  Lines       12815    12815           
=======================================
  Hits        11753    11753           
  Misses       1062     1062           
Flag Coverage Δ
unittests 91.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aeffce...ab4ff91. Read the comment docs.

@ethanwharris ethanwharris merged commit d15d4b6 into master Apr 15, 2022
@ethanwharris ethanwharris deleted the bugfix/torchmetrics_0_8 branch April 15, 2022 09:35
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing the same all day today in Lightning-AI/tutorials#158
the problem is that the latest release of pytorch-tabular=0.7.0 still requires PL 1.3.6 even though on master it is already updated so would be great to have new release 🐰

krshrimali pushed a commit that referenced this pull request Apr 27, 2022
ethanwharris added a commit that referenced this pull request Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working tests / CI Tests and continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants