Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing some notebooks [freezing] #334

Merged
merged 5 commits into from
Jul 22, 2024
Merged

fixing some notebooks [freezing] #334

merged 5 commits into from
Jul 22, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 22, 2024

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Mainly freezeing requirement is to make it pass again.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70%. Comparing base (8d4a7c2) to head (24db442).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #334   +/-   ##
===================================
- Coverage    70%    70%   -0%     
===================================
  Files         2      2           
  Lines       403    406    +3     
===================================
+ Hits        284    285    +1     
- Misses      119    121    +2     

@Borda Borda marked this pull request as ready for review July 22, 2024 15:32
@Borda Borda requested a review from ethanwharris as a code owner July 22, 2024 15:32
@Borda Borda added the bug / fix Something isn't working label Jul 22, 2024
@Borda Borda merged commit 7b418e8 into main Jul 22, 2024
19 checks passed
@Borda Borda deleted the fix/notebooks branch July 22, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working topic: CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant