Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #2800

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Remove deprecated code #2800

merged 6 commits into from
Oct 22, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Oct 22, 2024

What does this PR do?

Removes deprecated code.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2800.org.readthedocs.build/en/2800/

@SkafteNicki SkafteNicki self-assigned this Oct 22, 2024
@SkafteNicki SkafteNicki enabled auto-merge (squash) October 22, 2024 12:51
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69%. Comparing base (feae91e) to head (24731e1).
Report is 3 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2800   +/-   ##
======================================
- Coverage      69%     69%   -0%     
======================================
  Files         336     336           
  Lines       18216   18209    -7     
======================================
- Hits        12495   12489    -6     
+ Misses       5721    5720    -1     

@mergify mergify bot added the ready label Oct 22, 2024
@Borda Borda disabled auto-merge October 22, 2024 18:09
@Borda Borda merged commit c6e3956 into master Oct 22, 2024
56 checks passed
@Borda Borda deleted the deprecated_for_v1.6 branch October 22, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants