-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NISQA metric #2792
Add NISQA metric #2792
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2792 +/- ##
========================================
- Coverage 69% 35% -33%
========================================
Files 340 328 -12
Lines 18448 18525 +77
========================================
- Hits 12679 6539 -6140
- Misses 5769 11986 +6217 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @philgzl, thanks for this contribution to TM.
I am overall very happy with the PR already, it is nearly complete. If I could ask you to add some doc strings (just one liners is fine) to the different functions/methods in src/torchmetrics/functional/audio/nisqa.py
that would be great for later maintaining the code.
# main NISQA model definition | ||
# ported from https://github.com/gabrielmittag/NISQA | ||
# Copyright (c) 2021 Gabriel Mittag, Quality and Usability Lab | ||
# MIT License |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Borda we had copyright issue before, anything we need to do here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The model weights are also under CC BY-NC-SA license
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will need to get the authors to allow distribute it with an Apache licence
od can we import as an optional dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Original code is not a pip installable package so can't really import as an optional dependency.
DNSMOS is similar: MIT license code and CC BY license weights. How was this managed? Or was this overlooked?
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
# main NISQA model definition | ||
# ported from https://github.com/gabrielmittag/NISQA | ||
# Copyright (c) 2021 Gabriel Mittag, Quality and Usability Lab | ||
# MIT License |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will need to get the authors to allow distribute it with an Apache licence
od can we import as an optional dependency?
hote this is correct:
|
@Borda added full copyright at the top of the affected file, so PR should be good to go now |
What does this PR do?
This PR adds a new metric NISQA as suggested in #2464
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2792.org.readthedocs.build/en/2792/