-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump: support torch>=2.0
#2671
bump: support torch>=2.0
#2671
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2671 +/- ##
=======================================
- Coverage 70% 69% -1%
=======================================
Files 336 336
Lines 18235 18215 -20
=======================================
- Hits 12709 12494 -215
- Misses 5526 5721 +195 |
@Borda what is missing here? |
just last check and also we still hit this error:
|
@Borda install |
Alternative set |
wanted to avoid this freeze in tests...
I did freeze to latest |
@Borda yeah I also think it is time to revisit this. Will help also land another PR #2777 (comment) which is currently blocked by old PT versions |
What does this PR do?
remove active testing and raising unsupported warnings for older
torch
and relatedtorchvision
&torchaudio
Note that torch 2.0 was released for more than a year ago (Mar 2023) and seems there have been not additional releases bug-fix releases for the 1.X series since Dec 2022
close #2791
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2671.org.readthedocs.build/en/2671/