Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: support torch>=2.0 #2671

Merged
merged 76 commits into from
Oct 21, 2024
Merged

bump: support torch>=2.0 #2671

merged 76 commits into from
Oct 21, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 2, 2024

What does this PR do?

remove active testing and raising unsupported warnings for older torch and related torchvision & torchaudio
Note that torch 2.0 was released for more than a year ago (Mar 2023) and seems there have been not additional releases bug-fix releases for the 1.X series since Dec 2022

close #2791

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2671.org.readthedocs.build/en/2671/

@Borda Borda marked this pull request as ready for review August 5, 2024 10:49
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 10 lines in your changes missing coverage. Please review.

Project coverage is 69%. Comparing base (7f579eb) to head (6ccb5bc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #2671    +/-   ##
=======================================
- Coverage      70%     69%    -1%     
=======================================
  Files         336     336            
  Lines       18235   18215    -20     
=======================================
- Hits        12709   12494   -215     
- Misses       5526    5721   +195     

@mergify mergify bot added the has conflicts label Aug 5, 2024
@mergify mergify bot added the ready label Sep 4, 2024
@SkafteNicki
Copy link
Member

@Borda what is missing here?

@Borda
Copy link
Member Author

Borda commented Sep 4, 2024

what is missing here?

just last check and also we still hit this error:

Traceback (most recent call last):
  File "/__w/2/s/tests/unittests/nominal/test_cramers.py", line 64, in _reference_dython_cramers_v
    from dython.nominal import cramers_v
  File "/usr/local/lib/python3.10/dist-packages/dython/__init__.py", line 1, in <module>
    from . import nominal, model_utils, sampling, data_utils
  File "/usr/local/lib/python3.10/dist-packages/dython/model_utils.py", line 4, in <module>
    from scikitplot.helpers import binary_ks_curve
  File "/usr/local/lib/python3.10/dist-packages/scikitplot/__init__.py", line 2, in <module>
    from . import metrics, cluster, decomposition, estimators
  File "/usr/local/lib/python3.10/dist-packages/scikitplot/metrics.py", line 27, in <module>
    from scipy import interp
ImportError: cannot import name 'interp' from 'scipy' (/usr/local/lib/python3.10/dist-packages/scipy/__init__.py)

@SkafteNicki
Copy link
Member

@Borda install scipy==1.11.4 according to this issue: reiinakano/scikit-plot#119

@SkafteNicki
Copy link
Member

Alternative set dython>=0.7.5 as according to this issue: shakedzy/dython#156

@Borda
Copy link
Member Author

Borda commented Sep 4, 2024

install scipy==1.11.4 according to this issue: reiinakano/scikit-plot#119

wanted to avoid this freeze in tests...

Alternative set dython>=0.7.5 as according to this issue: shakedzy/dython#156

I did freeze to latest 0.7.7 and bump matplotlib >=3.6.0 which is still 2022

@Borda Borda requested a review from lantiga September 4, 2024 13:10
@SkafteNicki
Copy link
Member

@Borda yeah I also think it is time to revisit this. Will help also land another PR #2777 (comment) which is currently blocked by old PT versions

@mergify mergify bot removed the has conflicts label Oct 21, 2024
@SkafteNicki SkafteNicki modified the milestones: v1.5.0, v1.6.0 Oct 21, 2024
@Borda Borda merged commit 346bcdc into master Oct 21, 2024
61 checks passed
@Borda Borda deleted the bump/torch branch October 21, 2024 15:22
@Borda Borda mentioned this pull request Oct 22, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failing tests for PT 1.1x and python 3.10+
3 participants