-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix weird docker error #2581
Merged
Merged
Fix weird docker error #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks strange but if it helps...
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2581 +/- ##
======================================
Coverage 69% 69%
======================================
Files 314 314
Lines 17695 17696 +1
======================================
+ Hits 12197 12198 +1
Misses 5498 5498 |
Borda
reviewed
Jun 4, 2024
Borda
pushed a commit
that referenced
this pull request
Aug 2, 2024
(cherry picked from commit b0da59e)
Borda
pushed a commit
that referenced
this pull request
Aug 2, 2024
(cherry picked from commit b0da59e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2559
I have no idea what the actual issue is here. It is therefore up for discussion if this PR should be merged.
Apparently, using torchmetrics inside a docker image can lead to the following error:
which can happen due to so many reasons in my experience. See the issue for more details, but I was able to reproduce the issue on v1.4.0 of torchmetrics but not on v1.3.2, thus after running
git bisect
I was able to narrow it down to this commit cd7ccfc. Then removing each line one by one I could narrow it down to the data loader having some weird interaction with the requirement cache.I do not really think this is anything we can test for.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2581.org.readthedocs.build/en/2581/