Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unpredictable panoptic_quality output when return_per_class=True #2548

Merged
merged 5 commits into from
May 30, 2024

Conversation

i-aki-y
Copy link
Contributor

@i-aki-y i-aki-y commented May 19, 2024

What does this PR do?

Fix #2547

PanopticQuality can return per class score when return_per_class=True argument is given.
But the order of the result is unpredictable.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2548.org.readthedocs.build/en/2548/

Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36%. Comparing base (8d9d2ae) to head (e4fc7b8).
Report is 100 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (8d9d2ae) and HEAD (e4fc7b8). Click for more details.

HEAD has 168 uploads less than BASE
Flag BASE (8d9d2ae) HEAD (e4fc7b8)
Windows 9 3
python3.8 8 2
cpu 58 16
torch1.13.1+cpu 8 3
torch1.12.1+cpu 3 1
Linux 34 12
python3.9 24 8
torch1.11.0+cpu 3 1
torch2.3.0 3 1
macOS 15 1
python3.11 12 3
torch1.10.2+cpu 3 1
torch2.3.0+cpu 9 3
python3.10 14 3
torch2.0.1 6 0
torch2.0.1+cpu 8 3
torch1.13.1 3 0
torch2.2.2+cpu 6 2
torch2.1.2+cpu 3 1
torch2.2.2 3 0
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2548     +/-   ##
========================================
- Coverage      69%     36%    -33%     
========================================
  Files         314     314             
  Lines       17663   17663             
========================================
- Hits        12179    6334   -5845     
- Misses       5484   11329   +5845     

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add entry to the changelog

@mergify mergify bot added the ready label May 19, 2024
@i-aki-y
Copy link
Contributor Author

i-aki-y commented May 19, 2024

Added changelog entry.
Updated test codes to add missing test cases.

@SkafteNicki SkafteNicki enabled auto-merge (squash) May 30, 2024 12:08
@SkafteNicki SkafteNicki merged commit 53fbadf into Lightning-AI:master May 30, 2024
61 checks passed
Borda pushed a commit that referenced this pull request Aug 2, 2024
#2548)

* fix panoptic_quality class order

* added changelog and updated test-case

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

(cherry picked from commit 53fbadf)
Borda pushed a commit that referenced this pull request Aug 2, 2024
#2548)

* fix panoptic_quality class order

* added changelog and updated test-case

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

(cherry picked from commit 53fbadf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpredictable class order when panoptic_quality(..., return_per_class=True)
3 participants