Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type documentation of inception score #2467

Merged
merged 2 commits into from
Mar 24, 2024

Conversation

furkan-celik
Copy link
Contributor

@furkan-celik furkan-celik commented Mar 24, 2024

What does this PR do?

Fixes some typo on the documentation of InceptionScore. Return type mentioned on the documentation is wrong and misleading in it's current state.

Before submitting
  • [X Typo fix] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • [+] Did you read the contributor guideline, Pull Request section?
  • [+] Did you make sure to update the docs?
  • [+ Typo fix so no need for tests] Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2467.org.readthedocs.build/en/2467/

Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Merging #2467 (3dba426) into master (f021b03) will decrease coverage by 31%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2467     +/-   ##
========================================
- Coverage      69%     38%    -31%     
========================================
  Files         307     307             
  Lines       17357   17357             
========================================
- Hits        11957    6647   -5310     
- Misses       5400   10710   +5310     

@Borda Borda merged commit 78cbbf8 into Lightning-AI:master Mar 24, 2024
60 of 61 checks passed
@mergify mergify bot added the ready label Mar 24, 2024
Borda pushed a commit that referenced this pull request Mar 24, 2024
* Fix return type documentation of inception score
* fix too long line

---------

Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants