Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text: reduce lang. specific mecab-ko #2456

Merged
merged 8 commits into from
Apr 19, 2024
Merged

text: reduce lang. specific mecab-ko #2456

merged 8 commits into from
Apr 19, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 18, 2024

What does this PR do?

Reduce language specific, if need rather refer in docs

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2456.org.readthedocs.build/en/2456/

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Merging #2456 (dfc21e0) into master (d03ca5e) will decrease coverage by 29%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2456     +/-   ##
========================================
- Coverage      69%     40%    -29%     
========================================
  Files         307     307             
  Lines       17421   17421             
========================================
- Hits        11995    6946   -5049     
- Misses       5426   10475   +5049     

@Borda
Copy link
Member Author

Borda commented Mar 18, 2024

Well, this is strange that moving requirements to test's makes it fail on older versions...
any idea @stancld ?

@SkafteNicki SkafteNicki added this to the v1.4.0 milestone Apr 19, 2024
@mergify mergify bot added the ready label Apr 19, 2024
@Borda Borda merged commit 9d04667 into master Apr 19, 2024
69 of 70 checks passed
@Borda Borda deleted the req/mecab-ko branch April 19, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants