Skip to content

ci: use rich base image for integrations #2239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2023
Merged

ci: use rich base image for integrations #2239

merged 1 commit into from
Nov 24, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Nov 24, 2023

What does this PR do?

redo #2236 and 272ade5
the official docker image with pt 1.13 from last year was build on top of super old Ubuntu 18.04 and recently Azure expect to use node 20 which crashes with missing GLIBC_2.28
Tried following:

  • install GLIBC 2.28 on top of the pytorch/pytorch:1.13.1 but it fails
  • run upgrade dist within pytorch/pytorch:1.13.1 but also crashes
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2239.org.readthedocs.build/en/2239/

@Borda Borda added the test / CI testing or CI label Nov 24, 2023
@Borda Borda merged commit 9dd199a into master Nov 24, 2023
@Borda Borda deleted the ci/int branch November 24, 2023 21:27
Borda added a commit that referenced this pull request Nov 30, 2023
Borda added a commit that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant