-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: switch to custom docker images #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
SkafteNicki,
justusschock and
stancld
as code owners
October 1, 2023 13:45
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2123 +/- ##
=======================================
+ Coverage 85% 87% +2%
=======================================
Files 293 293
Lines 16324 16327 +3
=======================================
+ Hits 13818 14187 +369
+ Misses 2506 2140 -366 |
Let's rather start to build own dockers which would have a few side adventures:
|
for more information, see https://pre-commit.ci
Borda
changed the title
ci: debug azure & sudo [wip]
ci: switch to custom docker images [wip]
Oct 1, 2023
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Oct 1, 2023
for more information, see https://pre-commit.ci
|
Borda
changed the title
ci: switch to custom docker images [wip]
ci: switch to custom docker images & req. clarify
Oct 1, 2023
SkafteNicki
approved these changes
Oct 2, 2023
github-actions
bot
removed
the
documentation
Improvements or additions to documentation
label
Oct 2, 2023
justusschock
approved these changes
Oct 2, 2023
Borda
changed the title
ci: switch to custom docker images & req. clarify
ci: switch to custom docker images
Oct 2, 2023
matsumotosan
pushed a commit
to matsumotosan/metrics
that referenced
this pull request
Oct 4, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
matsumotosan
added a commit
to matsumotosan/metrics
that referenced
this pull request
Oct 14, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Borda
added a commit
that referenced
this pull request
Nov 30, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 886c09b)
Borda
added a commit
that referenced
this pull request
Dec 1, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 886c09b)
Borda
pushed a commit
to matsumotosan/metrics
that referenced
this pull request
May 21, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
debugging:Let's rather start to build own dockers which would have a few side adventures:
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2123.org.readthedocs.build/en/2123/