Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: switch to custom docker images #2123

Merged
merged 20 commits into from
Oct 2, 2023
Merged

ci: switch to custom docker images #2123

merged 20 commits into from
Oct 2, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 1, 2023

What does this PR do?

debugging:

++ head -1 /proc/self/cgroup
++ cut -d/ -f3
+ container_id=
+ echo 'debconf debconf/frontend select Noninteractive'
+ debconf-set-selections
+ /tmp/docker exec -t -u 0 sh -c 'apt-get update && DEBIAN_FRONTEND=noninteractive apt-get -o Dpkg::Options::=--force-confold -y install sudo'
Error response from daemon: No such container: sh

Let's rather start to build own dockers which would have a few side adventures:

  • cleaner workflow
  • slightly faster runs
  • better control over emv
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2123.org.readthedocs.build/en/2123/

@Borda Borda added the Priority Critical task/issue label Oct 1, 2023
@Borda Borda changed the title ci: debug azure & sudo ci: debug azure & sudo [wip] Oct 1, 2023
@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #2123 (0a8d1f6) into master (39ba91a) will increase coverage by 2%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #2123    +/-   ##
=======================================
+ Coverage      85%     87%    +2%     
=======================================
  Files         293     293            
  Lines       16324   16327     +3     
=======================================
+ Hits        13818   14187   +369     
+ Misses       2506    2140   -366     

@Borda
Copy link
Member Author

Borda commented Oct 1, 2023

Let's rather start to build own dockers which would have a few side adventures:

  • cleaner workflow
  • slightly faster runs
  • better control over emv

@Borda Borda changed the title ci: debug azure & sudo [wip] ci: switch to custom docker images [wip] Oct 1, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 1, 2023
@Borda
Copy link
Member Author

Borda commented Oct 1, 2023

took an advantage and renamed requirements' files meant purely for development (tests, docs, integrate) to separate that they are not meant clearly to be extras

@Borda Borda changed the title ci: switch to custom docker images [wip] ci: switch to custom docker images & req. clarify Oct 1, 2023
@mergify mergify bot added the has conflicts label Oct 2, 2023
@mergify mergify bot removed the has conflicts label Oct 2, 2023
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Oct 2, 2023
@Borda Borda enabled auto-merge (squash) October 2, 2023 08:50
@Borda Borda added the test / CI testing or CI label Oct 2, 2023
@Borda Borda changed the title ci: switch to custom docker images & req. clarify ci: switch to custom docker images Oct 2, 2023
@Borda Borda disabled auto-merge October 2, 2023 09:10
@Borda Borda enabled auto-merge (squash) October 2, 2023 09:10
@mergify mergify bot added the ready label Oct 2, 2023
@Borda Borda disabled auto-merge October 2, 2023 10:06
@Borda Borda merged commit 886c09b into master Oct 2, 2023
70 of 73 checks passed
@Borda Borda deleted the ci/azure branch October 2, 2023 10:06
matsumotosan pushed a commit to matsumotosan/metrics that referenced this pull request Oct 4, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
matsumotosan added a commit to matsumotosan/metrics that referenced this pull request Oct 14, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Borda added a commit that referenced this pull request Nov 30, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 886c09b)
Borda added a commit that referenced this pull request Dec 1, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 886c09b)
Borda pushed a commit to matsumotosan/metrics that referenced this pull request May 21, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Critical task/issue ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants