Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an inappropriate test expression to remove a logical short circuit #2082

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Fix an inappropriate test expression to remove a logical short circuit #2082

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9508c4
Comment: Fixed an inappropriate test expression to remove a logical s…
munahaf Sep 15, 2023
a7228a8
Merge branch 'master' into Inappropriate_Logic-1_mean_ap.py5097474515…
mergify[bot] Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/torchmetrics/detection/_mean_ap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ def _evaluate_image(
return self.__evaluate_image_gt_no_preds(gt, gt_label_mask, area_range, nb_iou_thrs)

# Some predictions but no GT
if len(gt_label_mask) == 0 and len(det_label_mask) >= 0:
if len(gt_label_mask) == 0 and len(det_label_mask) > 0:
return self.__evaluate_image_preds_no_gt(det, idx, det_label_mask, max_det, area_range, nb_iou_thrs)

gt = [gt[i] for i in gt_label_mask]
Expand Down
Loading