Improvements to docs on custom implementations #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
lantiga,
Borda,
justusschock and
stancld
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2061 +/- ##
=======================================
+ Coverage 85% 87% +2%
=======================================
Files 289 289
Lines 16125 16129 +4
=======================================
+ Hits 13648 14018 +370
+ Misses 2477 2111 -366 |
Borda
approved these changes
Sep 11, 2023
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
…g/metrics into docs_custom_impl
Borda
reviewed
Sep 11, 2023
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
justusschock
approved these changes
Sep 15, 2023
matsumotosan
pushed a commit
to matsumotosan/metrics
that referenced
this pull request
Sep 17, 2023
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
matsumotosan
pushed a commit
to matsumotosan/metrics
that referenced
this pull request
Sep 19, 2023
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2005
Trying to give the documentation on creating custom implementation an update.
As mentioned in the issue, some details especially regarding list metric states are missing.
Also did a bit of an update to the utilities section.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2061.org.readthedocs.build/en/2061/