Skip to content

Fix single update in pearson corrcoef #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Aug 23, 2023

What does this PR do?

Fixes #2014

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2019.org.readthedocs.build/en/2019/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Aug 23, 2023
@SkafteNicki SkafteNicki added this to the v1.1.x milestone Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #2019 (d35914a) into master (f6760b5) will decrease coverage by 48%.
Report is 1 commits behind head on master.
The diff coverage is 100%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2019     +/-   ##
========================================
- Coverage      87%     39%    -48%     
========================================
  Files         270     270             
  Lines       15574   15572      -2     
========================================
- Hits        13477    6059   -7418     
- Misses       2097    9513   +7416     

@mergify mergify bot added the ready label Aug 23, 2023
@stancld stancld merged commit 96b9439 into master Aug 23, 2023
@stancld stancld deleted the bugfix/pearson_single_update branch August 23, 2023 12:11
matsumotosan added a commit to matsumotosan/torchmetrics that referenced this pull request Aug 25, 2023
matsumotosan added a commit to matsumotosan/torchmetrics that referenced this pull request Sep 19, 2023
Borda pushed a commit to matsumotosan/torchmetrics that referenced this pull request Sep 19, 2023
Borda pushed a commit to matsumotosan/torchmetrics that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pearson Correlation Coefficient fails when updating one batch at a time
3 participants