-
Notifications
You must be signed in to change notification settings - Fork 429
Add speech-to-reverberation modulation energy ratio (SRMR) metric #1792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
83 commits
Select commit
Hold shift + click to select a range
16f92f3
+SRMR
quancs 08155e3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f5843ee
Merge branch 'master' into srmr
SkafteNicki 8e1f6f3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 8c370e4
update
quancs e8fe6ea
update
quancs 8c6fa8a
Merge branch 'srmr' of https://github.com/quancs/torchmetrics into srmr
quancs 698c6a4
update
quancs 14b7ec1
update
quancs b7317be
Merge branch 'master' into srmr
quancs 50f0511
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] ea46e37
fix
quancs 2ee6b47
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cb7c5f7
fix
quancs f6fead7
fix
quancs f571d97
fix
quancs f2557af
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c34ad65
update
quancs 9e33963
disbale differentiable test
quancs fc11680
Merge branch 'srmr' of https://github.com/quancs/torchmetrics into srmr
quancs ded7452
update
quancs e7d64a9
fix
quancs 1f1968d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7b23677
fix
quancs c878bae
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1b66bc7
change to lower letters
quancs c1b7b4c
merge
quancs 3c14017
update
quancs 7d58c56
Merge branch 'srmr' of https://github.com/quancs/torchmetrics into srmr
quancs c1655e6
fix
quancs df168db
fix
quancs 9c4e64e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3dfe378
remove assert
quancs a347417
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d72d90b
shit pre-commit
quancs 78dbe74
Merge branch 'srmr' of https://github.com/quancs/torchmetrics into srmr
quancs b244bf2
fix
quancs 809f777
Merge branch 'srmr' of https://github.com/quancs/torchmetrics into srmr
quancs 7761417
fix
quancs df5cbdc
fix
quancs 0ed8dae
fix
quancs 4f48e61
fix
quancs a6fa842
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b976ab0
fix
quancs c4489c9
srmrpy
quancs 345a818
update gammatone
quancs 3645aaf
Merge branch 'master' into srmr
SkafteNicki 892ad2e
Merge branch 'master' into srmr
SkafteNicki 042da5d
Update src/torchmetrics/audio/srmr.py
quancs 84992d4
Update src/torchmetrics/audio/srmr.py
quancs 39abb66
Update src/torchmetrics/audio/srmr.py
quancs 4752264
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6133b2f
Update src/torchmetrics/functional/audio/srmr.py
quancs 1ede251
Update tests/unittests/audio/test_srmr.py
quancs d6734ea
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3546ef4
add _srmr_arg_validate
quancs 278efda
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9d1c8b9
Merge branch 'master' into srmr
SkafteNicki 42404ff
fix ruff issues
SkafteNicki cc56270
add plot testing
SkafteNicki bd57e42
remove gammatone in requirements
quancs 18b4698
fix doc
quancs 9263be7
fix pi
quancs ea9c811
fix
quancs 48e0fc2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e066f71
add docs for lfilter
quancs 84737a7
update
quancs cc289dc
Merge branch 'master' into srmr
quancs 5598f87
add gammatone
quancs 06a5826
torchaudio>=0.10.0
quancs 221dd66
skip testing on missinig install
SkafteNicki fae0bc8
fix imports during testing
SkafteNicki 70b628d
fix plot import
SkafteNicki 8962749
skip conditional plot testing
SkafteNicki 8242f5c
srmr
SkafteNicki 968b391
skipping
SkafteNicki 03c1f6b
Merge branch 'master' into srmr
SkafteNicki 6521d4b
Merge branch 'master' into srmr
SkafteNicki bce9b9c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0b370a1
fix formatting
SkafteNicki 6ce353c
Merge branch 'master' into srmr
Borda 88e99f9
Merge branch 'master' into srmr
Borda 1e8145a
Update src/torchmetrics/audio/srmr.py
SkafteNicki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
docs/source/audio/speech_reverberation_modulation_energy_ratio.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
.. customcarditem:: | ||
:header: Speech-to-Reverberation Modulation Energy Ratio (SRMR) | ||
:image: https://pl-flash-data.s3.amazonaws.com/assets/thumbnails/audio_classification.svg | ||
:tags: Audio | ||
|
||
.. include:: ../links.rst | ||
|
||
###################################################### | ||
Speech-to-Reverberation Modulation Energy Ratio (SRMR) | ||
###################################################### | ||
|
||
Module Interface | ||
________________ | ||
|
||
.. autoclass:: torchmetrics.audio.srmr.SpeechReverberationModulationEnergyRatio | ||
:noindex: | ||
:exclude-members: update, compute | ||
|
||
Functional Interface | ||
____________________ | ||
|
||
.. autofunction:: torchmetrics.functional.audio.srmr.speech_reverberation_modulation_energy_ratio | ||
:noindex: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,179 @@ | ||
# Copyright The Lightning team. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
from typing import Any, Optional, Sequence, Union | ||
|
||
from torch import Tensor, tensor | ||
|
||
from torchmetrics.functional.audio.srmr import ( | ||
_srmr_arg_validate, | ||
speech_reverberation_modulation_energy_ratio, | ||
) | ||
from torchmetrics.metric import Metric | ||
from torchmetrics.utilities.imports import ( | ||
_GAMMATONE_AVAILABEL, | ||
_MATPLOTLIB_AVAILABLE, | ||
_TORCHAUDIO_AVAILABEL, | ||
_TORCHAUDIO_GREATER_EQUAL_0_10, | ||
) | ||
from torchmetrics.utilities.plot import _AX_TYPE, _PLOT_OUT_TYPE | ||
|
||
if not all([_GAMMATONE_AVAILABEL, _TORCHAUDIO_AVAILABEL, _TORCHAUDIO_GREATER_EQUAL_0_10]): | ||
__doctest_skip__ = ["SpeechReverberationModulationEnergyRatio", "SpeechReverberationModulationEnergyRatio.plot"] | ||
elif not _MATPLOTLIB_AVAILABLE: | ||
__doctest_skip__ = ["SpeechReverberationModulationEnergyRatio.plot"] | ||
|
||
|
||
class SpeechReverberationModulationEnergyRatio(Metric): | ||
"""Calculate `Speech-to-Reverberation Modulation Energy Ratio`_ (SRMR). | ||
|
||
SRMR is a non-intrusive metric for speech quality and intelligibility based on | ||
a modulation spectral representation of the speech signal. | ||
This code is translated from `SRMRToolbox`_ and `SRMRpy`_. | ||
|
||
As input to ``forward`` and ``update`` the metric accepts the following input | ||
|
||
- ``preds`` (:class:`~torch.Tensor`): float tensor with shape ``(...,time)`` | ||
|
||
As output of `forward` and `compute` the metric returns the following output | ||
|
||
- ``srmr`` (:class:`~torch.Tensor`): float scaler tensor | ||
|
||
.. note:: using this metrics requires you to have ``gammatone`` and ``torchaudio`` installed. | ||
Either install as ``pip install torchmetrics[audio]`` or ``pip install torchaudio`` | ||
and ``pip install git+https://github.com/detly/gammatone``. | ||
|
||
Args: | ||
fs: the sampling rate | ||
n_cochlear_filters: Number of filters in the acoustic filterbank | ||
low_freq: determines the frequency cutoff for the corresponding gammatone filterbank. | ||
min_cf: Center frequency in Hz of the first modulation filter. | ||
max_cf: Center frequency in Hz of the last modulation filter. If None is given, | ||
then 30 Hz will be used for `norm==False`, otherwise 128 Hz will be used. | ||
norm: Use modulation spectrum energy normalization | ||
fast: Use the faster version based on the gammatonegram. | ||
Note: this argument is inherited from `SRMRpy`_. As the translated code is based to pytorch, | ||
setting `fast=True` may slow down the speed for calculating this metric on GPU. | ||
|
||
Raises: | ||
ModuleNotFoundError: | ||
If ``gammatone`` or ``torchaudio`` package is not installed | ||
|
||
Example: | ||
>>> import torch | ||
>>> from torchmetrics.audio import SpeechReverberationModulationEnergyRatio | ||
>>> g = torch.manual_seed(1) | ||
>>> preds = torch.randn(8000) | ||
>>> srmr = SpeechReverberationModulationEnergyRatio(8000) | ||
>>> srmr(preds) | ||
tensor(0.3354) | ||
""" | ||
|
||
msum: Tensor | ||
total: Tensor | ||
full_state_update: bool = False | ||
is_differentiable: bool = True | ||
higher_is_better: bool = True | ||
plot_lower_bound: Optional[float] = None | ||
plot_upper_bound: Optional[float] = None | ||
|
||
def __init__( | ||
self, | ||
fs: int, | ||
n_cochlear_filters: int = 23, | ||
low_freq: float = 125, | ||
min_cf: float = 4, | ||
max_cf: Optional[float] = 128, | ||
norm: bool = False, | ||
fast: bool = False, | ||
**kwargs: Any, | ||
) -> None: | ||
super().__init__(**kwargs) | ||
if not _TORCHAUDIO_AVAILABEL or not _TORCHAUDIO_GREATER_EQUAL_0_10 or not _GAMMATONE_AVAILABEL: | ||
raise ModuleNotFoundError( | ||
"speech_reverberation_modulation_energy_ratio requires you to have `gammatone` and" | ||
" `torchaudio>=0.10` installed. Either install as ``pip install torchmetrics[audio]`` or " | ||
"``pip install torchaudio>=0.10`` and ``pip install git+https://github.com/detly/gammatone``" | ||
) | ||
_srmr_arg_validate( | ||
fs=fs, | ||
n_cochlear_filters=n_cochlear_filters, | ||
low_freq=low_freq, | ||
min_cf=min_cf, | ||
max_cf=max_cf, | ||
norm=norm, | ||
fast=fast, | ||
) | ||
|
||
self.fs = fs | ||
quancs marked this conversation as resolved.
Show resolved
Hide resolved
|
||
self.n_cochlear_filters = n_cochlear_filters | ||
quancs marked this conversation as resolved.
Show resolved
Hide resolved
|
||
self.low_freq = low_freq | ||
self.min_cf = min_cf | ||
self.max_cf = max_cf | ||
self.norm = norm | ||
self.fast = fast | ||
SkafteNicki marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
self.add_state("msum", default=tensor(0.0), dist_reduce_fx="sum") | ||
self.add_state("total", default=tensor(0), dist_reduce_fx="sum") | ||
|
||
def update(self, preds: Tensor) -> None: | ||
"""Update state with predictions.""" | ||
metric_val_batch = speech_reverberation_modulation_energy_ratio( | ||
preds, self.fs, self.n_cochlear_filters, self.low_freq, self.min_cf, self.max_cf, self.norm, self.fast | ||
).to(self.msum.device) | ||
|
||
self.msum += metric_val_batch.sum() | ||
self.total += metric_val_batch.numel() | ||
|
||
def compute(self) -> Tensor: | ||
"""Compute metric.""" | ||
return self.msum / self.total | ||
|
||
def plot(self, val: Union[Tensor, Sequence[Tensor], None] = None, ax: Optional[_AX_TYPE] = None) -> _PLOT_OUT_TYPE: | ||
"""Plot a single or multiple values from the metric. | ||
|
||
Args: | ||
val: Either a single result from calling `metric.forward` or `metric.compute` or a list of these results. | ||
If no value is provided, will automatically call `metric.compute` and plot that result. | ||
ax: An matplotlib axis object. If provided will add plot to that axis | ||
|
||
Returns: | ||
Figure and Axes object | ||
|
||
Raises: | ||
ModuleNotFoundError: | ||
If `matplotlib` is not installed | ||
|
||
.. plot:: | ||
:scale: 75 | ||
|
||
>>> # Example plotting a single value | ||
>>> import torch | ||
>>> from torchmetrics.audio import SpeechReverberationModulationEnergyRatio | ||
>>> metric = SpeechReverberationModulationEnergyRatio(8000) | ||
>>> metric.update(torch.rand(8000)) | ||
>>> fig_, ax_ = metric.plot() | ||
|
||
.. plot:: | ||
:scale: 75 | ||
|
||
>>> # Example plotting multiple values | ||
>>> import torch | ||
>>> from torchmetrics.audio import SpeechReverberationModulationEnergyRatio | ||
>>> metric = SpeechReverberationModulationEnergyRatio(8000) | ||
>>> values = [ ] | ||
>>> for _ in range(10): | ||
... values.append(metric(torch.rand(8000))) | ||
>>> fig_, ax_ = metric.plot(values) | ||
""" | ||
return self._plot(val, ax) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note this wont be installed with pypi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turned out this repo is not tested, so we shall not rely with parity on their numbers
ref: jfsantos/SRMRpy#15