Skip to content

update the lower and upper bounds of audio metrics #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 17, 2023

Conversation

quancs
Copy link
Member

@quancs quancs commented May 15, 2023

What does this PR do?

The current lower and upper ploting bounds for audio metrics are incorrect, this PR correct these bounds.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--1786.org.readthedocs.build/en/1786/

@quancs quancs changed the title change the lower and upper bounds of audio metrics update the lower and upper bounds of audio metrics May 15, 2023
@quancs quancs marked this pull request as ready for review May 16, 2023 06:01
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #1786 (b8e01b7) into master (ad61da4) will decrease coverage by 49%.
The diff coverage is 100%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1786     +/-   ##
========================================
- Coverage      87%     38%    -49%     
========================================
  Files         254     254             
  Lines       14222   14224      +2     
========================================
- Hits        12324    5335   -6989     
- Misses       1898    8889   +6991     

@Borda Borda enabled auto-merge (squash) May 16, 2023 20:35
@mergify mergify bot added the ready label May 16, 2023
@Borda Borda requested review from stancld and a team May 17, 2023 12:33
@Borda Borda self-assigned this May 17, 2023
@Borda Borda disabled auto-merge May 17, 2023 17:15
@Borda Borda merged commit d0904c5 into Lightning-AI:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants