fix max_det_threshold in MAP
#1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkroeber
requested review from
SkafteNicki,
Borda and
justusschock
as code owners
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1712 +/- ##
========================================
- Coverage 88% 40% -48%
========================================
Files 238 238
Lines 13360 13360
========================================
- Hits 11741 5368 -6373
- Misses 1619 7992 +6373 |
SkafteNicki
approved these changes
Apr 15, 2023
Borda
approved these changes
Apr 16, 2023
This was referenced May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When modifying the max_det_thresholds the modified values aren't applied for the calculation of the overall MAP yet. I backchecked that this is actually the way it is implemented in pycocotools in the first place, but guess that it is already a bug there because it makes no sense and also doesn't occur in the matlab implementation.