Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plotting 15/n #1638

Merged
merged 8 commits into from
Mar 21, 2023
Merged

Add plotting 15/n #1638

merged 8 commits into from
Mar 21, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Mar 21, 2023

What does this PR do?

Fixes part of #1406
Add plotting to a few more metrics (few classification metrics)

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the enhancement New feature or request label Mar 21, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Mar 21, 2023
@SkafteNicki SkafteNicki marked this pull request as ready for review March 21, 2023 09:33
@mergify mergify bot requested a review from a team March 21, 2023 10:17
@Borda Borda enabled auto-merge (squash) March 21, 2023 10:17
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #1638 (0b97cf7) into master (9055b99) will decrease coverage by 0%.
The diff coverage is 89%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1638   +/-   ##
======================================
- Coverage      89%     89%   -0%     
======================================
  Files         228     228           
  Lines       12323   12365   +42     
======================================
+ Hits        10910   10947   +37     
- Misses       1413    1418    +5     

@mergify mergify bot removed the has conflicts label Mar 21, 2023
@Borda Borda merged commit b613c50 into master Mar 21, 2023
@Borda Borda deleted the plotting/15 branch March 21, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants