Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Lock pytorch / torchvision version #4469

Merged
merged 1 commit into from
Nov 1, 2020
Merged

[deps] Lock pytorch / torchvision version #4469

merged 1 commit into from
Nov 1, 2020

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Nov 1, 2020

What does this PR do?

Lock pytorch / torchvision version not to fail on master once PyTorch releases new version

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added the ci Continuous Integration label Nov 1, 2020
@ydcjeff ydcjeff added this to the 1.0.x milestone Nov 1, 2020
@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

Merging #4469 into master will increase coverage by 1%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4469   +/-   ##
======================================
+ Coverage      92%     93%   +1%     
======================================
  Files         113     113           
  Lines        8278    8192   -86     
======================================
- Hits         7632    7621   -11     
+ Misses        646     571   -75     

@rohitgr7 rohitgr7 merged commit d537485 into master Nov 1, 2020
@rohitgr7 rohitgr7 deleted the deps branch November 1, 2020 18:17
Borda pushed a commit that referenced this pull request Nov 4, 2020
(cherry picked from commit d537485)
rohitgr7 pushed a commit that referenced this pull request Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants