Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CI for building dockers #3383

Merged
merged 11 commits into from
Sep 10, 2020
Merged

add CI for building dockers #3383

merged 11 commits into from
Sep 10, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 7, 2020

What does this PR do?

Fixes at this moment we do not have any test all dockers are buildable and we find it out just at master when the fist build is performed

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the ci Continuous Integration label Sep 7, 2020
@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #3383 into master will decrease coverage by 3%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #3383    +/-   ##
=======================================
- Coverage      90%     87%    -3%     
=======================================
  Files          98     101     +3     
  Lines        8073    8579   +506     
=======================================
+ Hits         7283    7440   +157     
- Misses        790    1139   +349     

@ydcjeff
Copy link
Contributor

ydcjeff commented Sep 9, 2020

Are we going to test this base-cuda docker build as well?
Right now, it's skipped...
https://github.com/PyTorchLightning/pytorch-lightning/runs/1087774602?check_suite_focus=true

@Borda
Copy link
Member Author

Borda commented Sep 9, 2020

Are we going to test this base-cuda docker build as well?
Right now, it's skipped... https://github.com/PyTorchLightning/pytorch-lightning/runs/1087774602?check_suite_focus=true

good catch, thx :]

README.md Show resolved Hide resolved
@Borda Borda added ready PRs ready to be merged and removed ready PRs ready to be merged labels Sep 9, 2020
@ydcjeff
Copy link
Contributor

ydcjeff commented Sep 9, 2020

@Borda https://github.com/PyTorchLightning/pytorch-lightning/blob/a2d14306f70ec9e2a83351819d9ad4b6de9ddb26/.github/workflows/ci_pt-conda.yml#L66

this needs to change, right?

@Borda
Copy link
Member Author

Borda commented Sep 9, 2020

@tgaddair it seems we have again some problem with installing Horovoed on conda env...

@Borda
Copy link
Member Author

Borda commented Sep 9, 2020

@ydcjeff it seems there is some problem with the Cuda docker (installing Horovod) and as you already have a ready update I ll comment it now and we ll uncomment in your PR

@Borda Borda added the ready PRs ready to be merged label Sep 9, 2020
@williamFalcon williamFalcon merged commit cbc4f6f into master Sep 10, 2020
build_args: PYTHON_VERSION=${{ matrix.python_version }},PYTORCH_VERSION=${{ matrix.pytorch_version }}
push: false
timeout-minutes: 40
# TODO: uncomment this with fixing CUDA docker, no need to increase mergify count
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why leave the comment if its in the history?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is another PR #3074

Copy link
Contributor

@nateraw nateraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine 😄

@Borda Borda deleted the tests/build-dockers branch September 10, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants