-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CI for building dockers #3383
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3383 +/- ##
=======================================
- Coverage 90% 87% -3%
=======================================
Files 98 101 +3
Lines 8073 8579 +506
=======================================
+ Hits 7283 7440 +157
- Misses 790 1139 +349 |
Are we going to test this |
good catch, thx :] |
@tgaddair it seems we have again some problem with installing Horovoed on conda env... |
e347646
to
43e406f
Compare
@ydcjeff it seems there is some problem with the Cuda docker (installing Horovod) and as you already have a ready update I ll comment it now and we ll uncomment in your PR |
4328013
to
dcf5220
Compare
build_args: PYTHON_VERSION=${{ matrix.python_version }},PYTORCH_VERSION=${{ matrix.pytorch_version }} | ||
push: false | ||
timeout-minutes: 40 | ||
# TODO: uncomment this with fixing CUDA docker, no need to increase mergify count |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why leave the comment if its in the history?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is another PR #3074
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine 😄
What does this PR do?
Fixes at this moment we do not have any test all dockers are buildable and we find it out just at master when the fist build is performed
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃