Skip to content

Conversation

@bhimrazy
Copy link
Collaborator

@bhimrazy bhimrazy commented Jan 21, 2026

What does this PR do?

Updates PyTorch versions in CI workflows to include 2.10

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the ci Continuous Integration label Jan 21, 2026
@bhimrazy bhimrazy marked this pull request as draft January 21, 2026 21:38
@codecov
Copy link

codecov bot commented Jan 21, 2026

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3308 1 3307 522
View the top 1 failed test(s) by shortest run time
tests/tests_pytorch/trainer/connectors/test_data_connector.py::tests.tests_pytorch.trainer.connectors.test_data_connector
Stack Traces | 0s run time
trainer/connectors/test_data_connector.py:425: in <module>
    (CombinedLoader(DataLoader(dataset=RandomDataset(32, 64), shuffle=True)), True),
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../.venv/lib/python3.13.../pytorch_lightning/utilities/combined_loader.py:288: in __init__
    self._flattened, self._spec = _tree_flatten(iterables)
                                  ^^^^^^^^^^^^^^^^^^^^^^^^
../../.venv/lib/python3.13.../pytorch_lightning/utilities/_pytree.py:21: in _tree_flatten
    return [pytree], LeafSpec()
                     ^^^^^^^^^^
.../homebrew/Cellar/python@3.13/3.13.11/Frameworks/Python.framework/Versions/3.13/lib/python3.13/warnings.py:594: in __new__
    warn(msg, category=category, stacklevel=stacklevel + 1)
E   FutureWarning: `isinstance(treespec, LeafSpec)` is deprecated, use `isinstance(treespec, TreeSpec) and treespec.is_leaf()` instead.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@mscheltienne
Copy link

Would it be possible to add a pre-release workflow which runs against the nightly build of torch? This would allow you to fix deprecations before they get released. e.g. #21326

@bhimrazy
Copy link
Collaborator Author

Would it be possible to add a pre-release workflow which runs against the nightly build of torch? This would allow you to fix deprecations before they get released. e.g. #21326

Thanks @mscheltienne for the suggestion! I’ll look into it and also discuss it with the leads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants