-
Notifications
You must be signed in to change notification settings - Fork 3.6k
LightningCLI instantiator receives values applied by instantiation links to set in hparams #20777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LightningCLI instantiator receives values applied by instantiation links to set in hparams #20777
Conversation
save_hyperparameters
consistent for CLI and hardcoded training for custom python objects
#20432
Please check the failing GPU stand-alone test:
|
Looking at the logs, in |
not sure why, but we added this silly line:
|
…nks to set in hparams (#20777) * Instantiator receives values applied by instantiation links to set in hparams (#20311). * Add cleandir to test_lightning_cli_link_arguments * fix install... --------- Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: Jirka B <j.borovec+github@gmail.com> (cherry picked from commit d032388)
What does this PR do?
Fixes
save_hyperparameters
when used throughLightningCLI
(feature introduced in #18105) so that target values of links applied for instantiation are included in hparams.Fixes #20311
Fixes #20147
Also adds an official way to disable #18105 (parameter
load_from_checkpoint_support
), which might be desired by some people, e.g #20432, #20726Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20777.org.readthedocs.build/en/20777/