-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor path release 2.5.1
[wip]
#20589
base: release/stable
Are you sure you want to change the base?
Conversation
Signed-off-by: withbest <seekseat@outlook.com.> (cherry picked from commit afe5708)
(cherry picked from commit efe311c)
When loading a pytorch-lightning model from MLFlow, I get `TypeError: Type parameter +_R_co without a default follows type parameter with a default`. This happens whenever doing `import pytorch_lightning as pl` which is done by packages like MLFlow. Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: Luca Antiga <luca.antiga@gmail.com> (cherry picked from commit ee7fa43)
* Fix TBPTT example * Make example self-contained * Update imports * Add test (cherry picked from commit 76f0c54)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: Jirka B <j.borovec+github@gmail.com> (cherry picked from commit 1b26ac4)
(cherry picked from commit 8c2d263)
* test: flaky terminated with signal SIGABRT * str (cherry picked from commit a944e77)
(cherry picked from commit b5eb92a)
* Update twine to 6.0.1 for Python 3.13 * Pin pkginfo * Go with twine 6.0.1 (cherry picked from commit 711abb4)
Bumps [Lightning-AI/utilities](https://github.com/lightning-ai/utilities) from 0.11.9 to 0.12.0. - [Release notes](https://github.com/lightning-ai/utilities/releases) - [Changelog](https://github.com/Lightning-AI/utilities/blob/main/CHANGELOG.md) - [Commits](Lightning-AI/utilities@v0.11.9...v0.12.0) --- updated-dependencies: - dependency-name: Lightning-AI/utilities dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit ea59e40)
(cherry picked from commit d902516)
(cherry picked from commit 9afcc58)
would need also #20509 |
⛈️ Required checks status: Has failure 🔴
Groups summary🟢 pytorch_lightning: Tests workflowThese checks are required after the changes to 🟢 pytorch_lightning: Azure GPU
These checks are required after the changes to 🔴 pytorch_lightning: Benchmarks
These checks are required after the changes to 🟢 fabric: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 lightning_fabric: CPU workflowThese checks are required after the changes to 🟢 lightning_fabric: Azure GPU
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 installThese checks are required after the changes to Thank you for your contribution! 💜
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/stable #20589 +/- ##
===============================================
Coverage 88% 88%
===============================================
Files 267 267
Lines 23380 23369 -11
===============================================
- Hits 20481 20478 -3
+ Misses 2899 2891 -8 |
(cherry picked from commit 4eda5a0)
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20589.org.readthedocs.build/en/20589/